src: add permission support to config file #60746
Conversation
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60746 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 703 703
Lines 208226 208252 +26
Branches 40145 40146 +1
=======================================
+ Hits 184352 184379 +27
- Misses 15884 15891 +7
+ Partials 7990 7982 -8
🚀 New features to boost your workflow:
|
RafaelGSS
left a comment
RafaelGSS
left a comment
There was a problem hiding this comment.
Left a suggestion, but I'm good landing it as it is and doing my suggestion in a follow up PR.
About the tests that were added, I don't think they really cover the permission guarantees, but I can improve that in a follow up PR. No problem.
| Run with the configuration file: | ||
|
|
||
| ```console | ||
| $ node --permission --experimental-default-config-file app.js |
There was a problem hiding this comment.
Can't we enable --permission by default if the "permission" object exists in the config-file? So users won't need to pass --permission.
There was a problem hiding this comment.
If that's the behaviour of the already present flags it should work out of the box! 🚀
There was a problem hiding this comment.
Yeah its would be an improvement we can do it in a followup, that also might require us to review the flags we support. For example --test is not supported in the config file but --watch is (I think its just a discrepancy). We have to standardize the behavior
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0b6ae6d |
6 participants
No description provided.