-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
test_runner: add mock-timers support for AbortSignal.timeout #60751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| 'use strict'; | ||
|
|
||
| // eslint-disable-next-line no-unused-vars | ||
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
| const { MockTimers } = require('internal/test_runner/mock/mock_timers'); | ||
|
Check failure on line 6 in test/parallel/test-mock-timers-abortsignal-timeout.js
|
||
| const { AbortSignal } = require('internal/abort_controller'); | ||
|
|
||
| { | ||
| const mock = new MockTimers(); | ||
| mock.enable({ apis: ['AbortSignal.timeout'] }); | ||
|
|
||
| try { | ||
| const signal = AbortSignal.timeout(50); | ||
|
|
||
| assert.strictEqual(signal.aborted, false); | ||
|
|
||
| mock.tick(49); | ||
| assert.strictEqual(signal.aborted, false); | ||
|
|
||
| mock.tick(1); | ||
| assert.strictEqual(signal.aborted, true); | ||
| } finally { | ||
| mock.reset(); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AbortSignal.timeout()exists in all supported versions of Node.js, so this conditional is unnecessary; the internal property will always be defined if this code is reached.