Skip to content

Conversation

@PaulyBearCoding
Copy link

The fullName property exists on SuiteContext at runtime but was not documented.

Tested to verify behavior:

  • Top-level suite: returns suite name
  • Nested suite: returns "Parent > Child" format
  • Implementation confirmed in lib/internal/test_runner/test.js (line 495)

Fixes: #60757

Add documentation for the missing fullName property in SuiteContext class.
This property returns the name of the suite and each of its ancestors,
separated by '>'.

The property has been available since v22.3.0 but was missing from the
documentation.

Fixes: nodejs#60757
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Nov 17, 2025
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just not sure about the version number otherwise lgtm

### `context.fullName`

<!-- YAML
added: v22.3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is correct or not.

Here is the commit adding this: 90e81aa

And PR url: #53169

I think it was backported as far back as v20.16.0 so would that be the more accurate version for this?

Copy link
Member

@Renegade334 Renegade334 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docblock for TestContext#fullName (same commit as this one, presumably that's what this PR is mirroring) didn't get REPLACEME'd when merged to v20.x, for whatever reason. Both could be amended to add the v20.x version to the list, but it should be kept consistent either way.

Copy link
Member

@Renegade334 Renegade334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please address the commit linter error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SuiteContext missing fullName property that exists at runtime

4 participants