Skip to content

Conversation

@targos
Copy link
Member

@targos targos commented Nov 21, 2025

Refs: #59828

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 21, 2025
@targos
Copy link
Member Author

targos commented Nov 21, 2025

If there's a good reason to keep it, we should instead put a comment and disable compiler warnings.

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (d729bec) to head (93d241e).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60802      +/-   ##
==========================================
- Coverage   88.55%   88.54%   -0.02%     
==========================================
  Files         703      703              
  Lines      208259   208259              
  Branches    40162    40170       +8     
==========================================
- Hits       184415   184393      -22     
- Misses      15844    15861      +17     
- Partials     8000     8005       +5     
Files with missing lines Coverage Δ
src/node.h 95.91% <ø> (ø)

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@targos targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 23, 2025
@targos targos added dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Nov 25, 2025
@targos targos changed the title src: remove unused private field src: mark unused private field as such Nov 25, 2025
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 25, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2025
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants