Add contribute link to navbar

[bmuenzenmeyer]

Description

Does the simplest thing we can to improve visibility of contribution, while avoiding some of the problems we encountered with the version support docs.

As @joyeecheung accurately points out, directly linking to this content is the best way to keep it up to date.

Open to iteration, but I wanted to advance the conversation with a concrete implementation.

Validation

See the preview build

Related Issues

closes #7237

Check List

• I have read the Contributing Guidelines and made commit messages that follow the guideline.
• I have run npm run format to ensure the code follows the style guide.
• I have run npm run test to check if all tests are passing.
• I have run npx turbo build to check if the website builds without errors.
• I've covered new added functionality with unit tests if necessary.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)

• apps/site/navigation.json: Language not supported
• packages/i18n/locales/en.json: Language not supported

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Nov 25, 2024 7:03pm

[mikeesto]

LGTM, I think this is a good approach given the issues discussed

[bmuenzenmeyer]

todo: we also need a redirect

[bmuenzenmeyer]

@joyeecheung this was your original idea. we now have:

• top-level contributing link going to the nodejs/node CONTRIBUTING file
• contributing link in the about/get involved going to the same
• a redirect in place to the same
• deleted the duplicate content

can you think of anything else?

[github-actions]

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	90.79% (631/695)	72.44% (184/254)	94.53% (121/128)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
143	0 💤	0 ❌	0 🔥	5.291s ⏱️

[joyeecheung]

Thanks for opening the PR! Looks good as far as I can tell, but I do wonder if we should keep the original contribute page and just leave a link in there to CONTRIBUTING.md, in case there are any external websites already linking to the removed page and the URL would be broken (if we think nobody is linking to it then it's fine to just remove, though it seems plausible to me).

[mikeesto]

Thanks for opening the PR! Looks good as far as I can tell, but I do wonder if we should keep the original contribute page and just leave a link in there to CONTRIBUTING.md, in case there are any external websites already linking to the removed page and the URL would be broken (if we think nobody is linking to it then it's fine to just remove, though it seems plausible to me).

That's a good point although I think this redirect should help avoid breaking things: https://github.com/nodejs/nodejs.org/pull/7274/files#diff-5ca5a80a6f81808f1779e8216ad41ca807d50397070d24bc8b4cc72653c84f0bR268-R269

[joyeecheung]

Oh right I didn't understand what it was doing at first. In that case LGTM, thanks!