Skip to content

remove istanbule ignore and add test for bad upgrade#1279

Merged
mcollina merged 1 commit intonodejs:mainfrom
is2ei:reduce-istanbul-ignore
Mar 15, 2022
Merged

remove istanbule ignore and add test for bad upgrade#1279
mcollina merged 1 commit intonodejs:mainfrom
is2ei:reduce-istanbul-ignore

Conversation

@is2ei
Copy link
Copy Markdown
Contributor

@is2ei is2ei commented Mar 15, 2022

This PR partially fixes #706.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 15, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.11%. Comparing base (2d7059b) to head (d62e9ac).
⚠️ Report is 2133 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1279   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files          44       44           
  Lines        4096     4098    +2     
=======================================
+ Hits         3855     3857    +2     
  Misses        241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina
Copy link
Copy Markdown
Member

Thanks!!

@mcollina mcollina merged commit 2336d25 into nodejs:main Mar 15, 2022
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Try to remove istanbul ignore

3 participants