abort request with reason if one is provided

[KhafraDev]

fixes #2590

[KhafraDev]

might be a major change, marking it as such just to be safe

[mcollina]

I don't think this is a major change.

[codecov-commenter]

Codecov Report

Attention: 155 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (cca97ad) 84.78%.
Report is 200 commits behind head on main.

Files	Patch %	Lines
lib/fetch/index.js	67.29%	52 Missing ⚠️
lib/fetch/util.js	37.17%	49 Missing ⚠️
lib/handler/RetryHandler.js	74.35%	30 Missing ⚠️
lib/api/readable.js	88.88%	5 Missing ⚠️
lib/fetch/headers.js	90.19%	5 Missing ⚠️
lib/client.js	93.44%	4 Missing ⚠️
lib/compat/dispatcher-weakref.js	57.14%	3 Missing ⚠️
lib/core/util.js	95.55%	2 Missing ⚠️
lib/fetch/request.js	93.93%	2 Missing ⚠️
lib/core/request.js	98.21%	1 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2592      +/-   ##
==========================================
- Coverage   85.54%   84.78%   -0.77%     
==========================================
  Files          76       80       +4     
  Lines        6858     7250     +392     
==========================================
+ Hits         5867     6147     +280     
- Misses        991     1103     +112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[KhafraDev]

hopefully a flaky test?

 not ok 2 - test/ca-fingerprint.js # time=515.802ms
  ---
  env: {}
  file: test/ca-fingerprint.js
  timeout: 60000
  command: C:\hostedtoolcache\windows\node\18.19.0\x64\node.exe
  args:
    - --expose-gc
    - test/ca-fingerprint.js
  stdio:
    - 0
    - pipe
    - 2
  cwd: D:\a\undici\undici
  exitCode: null
  signal: SIGTERM
  ...

[KhafraDev]

I'm not sure if it's a major change, it does change the errors you get when a reason isn't passed to abort. We made this change/fix in fetch when it was still experimental.

[metcoder95]

I'm a little bit over the fence, but I believe it can pass under a minor.
I don't see we are breaking contracts with current usage, in any case we are extending it as we are adding now the reason if exists, otherwise we fallback to the RequestAbortedError which they must handle already