Remove scripty #135
Merged
Remove scripty #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonkarns
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a big fan of scripty but we're removing it here.
As a devDependency, it's not possible to rely on scripty to run
pre/post/install scripts. Because of this, some package scripts can
leverage scripty, and some can't; but it's not immediately obvious which
and why. Therefore, I think it's best to remove scripty so it's not
accidentally used in an install-time script.
Scripty should probably be limited to application usage and not
libraries.
(Side benefit, we'll stop getting security notices for all of lodash
which is only a transitive devDep.)