Fix travis #86
Merged
Fix travis #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis says that build configuration variables are available to conditional checks, but not the build _environment_. > Also, environment variables from your build configuration (.travis.yml) and repository settings are available, and can be matched using env(FOO), see below. > Note that this means conditions do not have access to the build environment So is TRAVIS_COMMIT_RANGE considered build config or build env? Who knows! But the main concern is that TRAVIS_COMMIT_RANGE is blank for the initial push of a new branch. So let's just disable the verification build for pushes entirely. (Not optimal, but that's what travis is forcing us into.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis says that build configuration variables are available to
conditional checks, but not the build environment.
So is TRAVIS_COMMIT_RANGE considered build config or build env? Who
knows!
But the main concern is that TRAVIS_COMMIT_RANGE is blank for the
initial push of a new branch. So let's just disable the verification
build for pushes entirely. (Not optimal, but that's what travis is
forcing us into.)
fixes #42