Add instructions on how to install and run modules in README.md #526
Conversation
README.md
Outdated
| npm install javascripting | ||
| ``` | ||
|
|
||
| From within the `node_school` directory now run `node_modules/learnyounode/bin/javasripting` to start it. |
There was a problem hiding this comment.
Found some issues with this part, depending on the npm version, packages get installed in different routes.
How do you feel with something like this:
node_modules/learnyounode/bin/javascripting
(Or depending on the NPM version, it could be)
node_modules/.bin/javascripting
(PS: package name javascripting is misspelled)
There was a problem hiding this comment.
npm bin refers to the path it is run. In a regular bash it is possible to simply run
`npm bin`/learnyounode
(Also there is a typo for "javascripting" in the text)
|
Besides those 2 small details, LGTM 👍 |
|
Hey guys fix the typos and sent another PR, let me know what you think. I added two pictures to the README, could a second pair of eyes double check the pics are displaying properly please. |
|
LGTM 👍 |
|
Thank you @dantesolis, this is a very nice addition to the Readme, thank you @fforres for the review! |
3 participants
From this ISSUE thread