fix: clean up env directory after failure#61
Merged
richardlau merged 1 commit intonodeshift:mainfrom Aug 20, 2021
Merged
Conversation
Member
Author
|
I've pushed this up as-is as it is the end of my working day. I'd like to add a test for this somehow. |
richardlau
commented
Aug 20, 2021
If a module fails to install, clean up the env directory before attempting the next module.
Member
|
I think for this specific case that is enough since the cleanEnvDirectory is already covered by tests Also npcheck has no cli.js test yet, and creating a test for this also means checking the error messages and etc. ofc is doable but I don't think that should be done now to cover that change on cli.js 👍 |
helio-frota
approved these changes
Aug 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a module fails to install, clean up the env directory before
attempting the next module.