fix: return response data for cache hits#62
Merged
richardlau merged 1 commit intonodeshift:mainfrom Aug 24, 2021
Merged
Conversation
Return only the response data on cache hits for consistency with non-cache hits.
Member
|
@richardlau so basically the cache mechanism that I introduced didn't really work all this time 😅 |
aalykiot
approved these changes
Aug 24, 2021
helio-frota
approved these changes
Aug 24, 2021
Member
Author
Seems that way... I guess previously we didn't have a code path that tried to get the same URL as a previous |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return only the response data on cache hits for consistency with
non-cache hits.