github url now broken

[matt-oc]

I think @mcdonnelldean got a bit too exuberant with the tidying and removed the code to format the url correctly 😁

[mcdonnelldean]

These are the ones I have,

urlRepo: msg.url || '',
urlClone: repo.clone_url || '',

These two return valid data. The names are reversed though.

[matt-oc]

Yes but the formatting is incorrect for copying and using, we found out a few months ago that what is returned can be loads of different formats, some work some don't so it needs code to manually do it for reliability. We also don't need a clone url, its the same as the normal one 😄

[mcdonnelldean]

Thats not correct. There should be two urls, one for the project location and one for the code.

[matt-oc]

Yea? the normal url works fine for cloning and pushing etc, we tested it out

[mcdonnelldean]

On Githb the difference is just adding .git at the end, but this is not always true, we need to have the concept of the url the repo lives and the url that is cloned from

[mcdonnelldean]

The copy version would be the clone, the link version is what you use against the button to go to github.

[matt-oc]

I guess it makes sense in the case repos will be stored somewhere other than github where it may not work the same

[mcdonnelldean]

@matt-oc Having one rule for some and another rule for others is confusing. The concept of a clone url vs a project url is well known. What part of this url scheme breaks for you?

[mcdonnelldean]

We basically need these:

  "git_url": "git:\/\/github.com\/lodash\/lodash.git",
  "ssh_url": "git@github.com:lodash\/lodash.git",
  "clone_url": "https:\/\/github.com\/lodash\/lodash.git",

[matt-oc]

@mcdonnelldean thats ok I can roll with that, the issue is from github the url can come in the format: https://github.com/nodezoo which is great but it also come like this:

ssh://git@ and
git@github.com:user/module etc

and these dont work properly due to how the git module returns them so they need manual formatting

[mcdonnelldean]

So they are different urls. They do different things. Were exactly are you using this url? the one that's broken?

[matt-oc]

When we call our git module to go get the repo it returns the url that you have assigned to url so sometimes the url will go out as ssh://git@nodezoo.. etc which cant be used for cloning or as a link

[mcdonnelldean]

So this one is the problem: urlClone: repo.clone_url || '',

[matt-oc]

now fixed