Skip to content

Conversation

@nohr-ai
Copy link
Owner

@nohr-ai nohr-ai commented Sep 12, 2023

Added initial documentation for the package

  • Ignore magic methods and explicit hidden stuff

…explicit hidden functions left out by sphinx
@nohr-ai nohr-ai added the documentation Improvements or additions to documentation label Sep 12, 2023
@nohr-ai nohr-ai requested a review from mrtz-j September 12, 2023 16:40
@nohr-ai nohr-ai self-assigned this Sep 12, 2023
@nohr-ai nohr-ai merged commit d2b4d16 into beta Sep 12, 2023
@nohr-ai nohr-ai deleted the o/dev branch September 12, 2023 17:04
Copy link
Collaborator

@mrtz-j mrtz-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

async def create(cls, access_token: str, org_name: str) -> "MasterBlaster":
"""
Create a new MasterBlaster instance
Create a new fully setup MasterBlaster instance
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it sounds better, just a small nitpick.

Suggested change
Create a new fully setup MasterBlaster instance
Create a new, fully configured MasterBlaster instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants