Install Nodes missing validation of exclude drives

[guymguym]

Environment info

• Version: 1.3
• Deployment: AZURE
• Customer: Jenkins-test-server

Actual behavior

1. There is no validation on excluded drives
2. Also the boxes around the drives are almost invisible which is not comfortable for identifying it.

Expected behavior

1. Should validate basic format - for windows X: or \\network\... and for linux /path

Steps to reproduce

1. Enter numbers in the edit box

Screenshots or Logs or other output that would be helpful

[nimrod-becker]

@tamireran what do you think ?
Linux is very permissive

[tamireran]

@nimrod-becker I would start with very basic validation. We will learn more in the field.

[nimrod-becker]

@tamireran which is ? almost everything is allowed for linux names

[tamireran]

@nimrod-becker maybe this one can help. http://stackoverflow.com/questions/6416065/c-sharp-regex-for-file-paths-e-g-c-test-test-exe/42036026#42036026

[tamireran]

I don't have other ideas. Let's start with windows validation. We will try to compile a better solution later on.

[nimrod-becker]

@tamireran windows validation for all ? this won't work for sure

[tamireran]

@nimrod-becker As discussed, I think we should have the windows/linux selection before the drive selection, so you will have the right validation in place.

[nimrod-becker]

@tamireran then we are in disagreement :) I think its much better the way we have it now

[tamireran]

Now we don't have validation, which means that the user can make mistakes and we can't tell him what went wrong. You need to provide validation or a clear message about a problem that happened during the installation. Like always, feel free to provide any other solution. We can release it like that until we have a good idea, but keep this bug open with high priority.

…

On Sun, Apr 30, 2017 at 10:38 PM, Nimrod Becker ***@***.***> wrote: @tamireran <https://github.com/tamireran> then we are in disagreement :) I think its much better the way we have it now — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2764 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADt7omsbL1uxUBCJ4vnIXvwGgPxHS__Fks5r1W_tgaJpZM4Mchuv> .

[nimrod-becker]

@shirimordechay @tamireran
Passed to Shiri, maybe show during the drive config indications regarding correctness of the drives per each OS type or something.

[shirimordechay]

@guymguym @nimrod-becker @tamireran Validation in a place we can't actually validate all the way (for example in a case of a typo or wrong drive name) seems more confusing than helpful to me. We don't know if the user wants to type both windows and linux drive names and we won't know what to validate. At this point, since this didn't came from a user i would leave it- once we'll get some feedback on this process we'll know if it's necessary.

and about the tag color- no problem, we will change it.