Fix data optimization when compression is disabled

[romayalon]

Signed-off-by: Romy romy2232@gmail.com

Explain the changes

1. When compression is disabled pick the original size of the chunk instead of the compressed size.

Issues: Fixed #xxx / Gap #xxx

1. Fixed BZ #1842254 (comment 4)

Testing Instructions:

[guymguym]

@romayalon Notice that config.CHUNK_CODER_COMPRESS_TYPE is only a default value, but each chunk actually refers to a chunk_coder (a DB collection) where we define the compress_type configuration which applies to that chunk. This is meant to provide flexibility to have chunks with different compression types in the same system or bucket (for example disable compression for already-compressed media files, or switch to another compression).

So I think we should fix it in map_aggregate_chunks() to use size if compress_size is unset - this makes sense because when a chunk used "no" compression then freely speaking the compressed size is the same as size, it's just that we didn't store it in the DB. This fix should keep everything else intact and also account compress_size correctly for when we disable compression altogether.

WDYT?

function map_aggregate_chunks() {
    const compress_size = this.compress_size || this.size;
    emit(['', 'compress_size'], compress_size);
    emit([this.bucket, 'compress_size'], compress_size);
}

[romayalon]

@guymguym agreed and fixed.

[jeniawhite]

@guymguym @nimrod-becker @romayalon
This needs to be updated in PostgreSQL PL/PGSQL as well.

[guymguym]

@romayalon use compress_size here too

[guymguym]

and not this.compress_size...
FYI @nimrod-becker

[nimrod-becker]

ah!

[guymguym]

@jeniawhite Right.
Can you point out where?
Best if you can add a comment with a permalink to the source.

[jeniawhite]

@guymguym
https://github.com/noobaa/noobaa-core/blob/master/src/util/sql_functions/map_aggregate_chunks.sql
I will do that later in an additional PR.