Skip to content

Fix delete external connection #6385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2021
Merged

Fix delete external connection #6385

merged 1 commit into from
Feb 21, 2021

Conversation

@romayalon
Copy link
Contributor

Signed-off-by: Romy romy2232@gmail.com

Explain the changes

  1. Changed in delete_external_connection - instead of filtering system store connections (which are plain), just pulled the connection by its name.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed BZ#1931191

Testing Instructions:

@romayalon
fix delete external connection
ee169d4 
Signed-off-by: Romy <romy2232@gmail.com>
@romayalon romayalon requested a review from jeniawhite February 21, 2021 16:43
@romayalon romayalon merged commit d32a0c6 into noobaa:master Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nimrod-becker nimrod-becker nimrod-becker approved these changes

@jeniawhite jeniawhite Awaiting requested review from jeniawhite

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romayalon @nimrod-becker