Skip to content

Conversation

@codecap
Copy link

@codecap codecap commented Jul 29, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 808dbc2 on vladnazarenko:vna/mods into bab9f64 on nosolutions:master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pull request, just one thing: does the tsm client work without dsm.opt? if config_opt_hash is undef in your pull request we do not create dsm.opt (if i'm right). afaik the client needs dsm.opt even if it's empty. maybe we should move the old dsm.opt resource into an else part of the if statement...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

To be honest I don't know, in our setup we need the dsm.opt file with some options in it. Some months ago this module did not provided that file at all, now it's emtpy file, so I assumed not to create it, when we do not have a content for it.

But id you think we need it, let us remove the if statement ...

@tosmi
Copy link
Member

tosmi commented Jul 30, 2014

ok, i'm gonna merge this, but i have to check if tsm works without dsm.opt. so a new release (0.3.0) will take a few days.

thanks
toni

tosmi added a commit that referenced this pull request Jul 30, 2014
add: support for dsm.opt file
@tosmi tosmi merged commit 9c9723c into nosolutions:master Jul 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants