Skip to content

Added C++/WinRT as nuget reference #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Added C++/WinRT as nuget reference #10

wants to merge 1 commit into from

Conversation

@GurliGebis
Copy link
Contributor

@GurliGebis GurliGebis commented Mar 29, 2023

This adds the C++/WinRT nuget package, so it is updated to the latest headers, like Microsoft recommends.

This fixes #7

@GurliGebis GurliGebis mentioned this pull request Mar 29, 2023
Closed
@GurliGebis
Copy link
Contributor Author

GurliGebis commented Mar 29, 2023

Ping @donho, in case you don't get notifications on new PRs

donho
donho requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@donho donho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if it's really need the nuget system.

framework.h
#include "winrt/base.h"
#include "winrt/Windows.ApplicationModel.h"
#include "winrt/Windows.Foundation.Collections.h"
#include "winrt/Windows.Management.Deployment.h"
Copy link
Member

@donho donho Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these change? For me to include system headers the right syntax is #include <winrt/base.h> instead of #include "winrt/base.h".

Copy link
Contributor Author

@GurliGebis GurliGebis Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It switches from the ones provided by Visual Studio to the nuget versions

@GurliGebis
Copy link
Contributor Author

GurliGebis commented Mar 30, 2023

@donho the idea of using the headers from there, is that they can be kept up to date.
Microsoft releases new version with bugfixes regularly, and to keep it decoupled from the installed VS version (Since you cannot be sure everyone has the same version and update installed), they recommend using the nuget version of the headers instead 🙂

@donho donho closed this in e982670 Mar 30, 2023
@GurliGebis GurliGebis deleted the missing-nuget branch March 30, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@donho donho donho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

C++/WinRT NuGet missing

2 participants

@GurliGebis @donho