Skip to content

Conversation

@GurliGebis
Copy link
Contributor

This adds a resource file for versioning the dll, with the metadata for version 8.5.2
This should fix #16

@GurliGebis
Copy link
Contributor Author

@donho is this what you mean by versioning? 🙂

@donho donho self-assigned this Apr 5, 2023
Copy link
Member

@donho donho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rc file is considered as binary. could you fix that please?

@GurliGebis
Copy link
Contributor Author

@donho Sure, I'll try 🙂- right now it seems like git is insisting it is a binary file.
I'll see what I can do.

@GurliGebis GurliGebis force-pushed the versioning branch 2 times, most recently from 9390fac to 8798ace Compare April 5, 2023 19:54
@GurliGebis
Copy link
Contributor Author

@donho fixed - it was Visual Studio insisting on using UTF-16 with a BOM, causing git to insist it is a binary file.
Changed it to UTF-8, and now it works 🙂

Copy link
Member

@donho donho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider the suggestions

@GurliGebis
Copy link
Contributor Author

@donho I have updated the metadata as we talked about above 🙂

@GurliGebis
Copy link
Contributor Author

@donho also, can you include this in the 8.5.2 release? (Since we really should be having versioning info in the dll)

@donho
Copy link
Member

donho commented Apr 6, 2023

@donho also, can you include this in the 8.5.2 release? (Since we really should be having versioning info in the dll)

@GurliGebis
Notepad++ v8.5.2 has been released 3 hours ago:
https://notepad-plus-plus.org/news/v852-released/

It (the commit of this PR) will go into v8.5.3 for sure :)

@donho donho closed this in 1a5d018 Apr 6, 2023
@GurliGebis
Copy link
Contributor Author

@donho great, thanks.
And contratz on 8.5.2 - it's been an interresting release 😀🚀

@GurliGebis GurliGebis deleted the versioning branch April 6, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add versioning

2 participants