-
Notifications
You must be signed in to change notification settings - Fork 18
Added resource file for version info #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@donho is this what you mean by versioning? 🙂 |
donho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rc file is considered as binary. could you fix that please?
|
@donho Sure, I'll try 🙂- right now it seems like git is insisting it is a binary file. |
9390fac to
8798ace
Compare
|
@donho fixed - it was Visual Studio insisting on using UTF-16 with a BOM, causing git to insist it is a binary file. |
donho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider the suggestions
|
@donho I have updated the metadata as we talked about above 🙂 |
|
@donho also, can you include this in the 8.5.2 release? (Since we really should be having versioning info in the dll) |
@GurliGebis It (the commit of this PR) will go into v8.5.3 for sure :) |
|
@donho great, thanks. |
This adds a resource file for versioning the dll, with the metadata for version 8.5.2
This should fix #16