Skip to content

fix Win11 Explorer crash in SafeMode due to NppShell unhandled exception #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix Win11 Explorer crash in SafeMode due to NppShell unhandled exception #46

wants to merge 1 commit into from

Conversation

@xomx
Copy link
Contributor

@xomx xomx commented Sep 30, 2023

Fixes #45 .

Sparse packages handling does not work in the Windows OS SafeMode.
But the NppShell classic-menu functionality remains fully functional there (even with this patch).

@xomx
fix Win11 Explorer crash in SafeMode due to NppShell unhandled exception
bc234a0 
Sparse packages handling does not work in the Windows OS SafeMode.
@xomx
Copy link
Contributor Author

xomx commented Sep 30, 2023

Hello @GurliGebis
I quick-patched, as this is a nasty bug influencing any computer with the new shell extension installed.
If you have a better solution (one could e.g. use try/catch also in the NppShell::Installer::RegisterSparsePackage() ), just say so and I will close this PR.

GurliGebis
GurliGebis approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@GurliGebis GurliGebis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@GurliGebis
Copy link
Contributor

GurliGebis commented Sep 30, 2023

@donho This should be merged, to avoid safemode issues.

@donho donho self-assigned this Oct 1, 2023
@donho
Copy link
Member

donho commented Oct 1, 2023

@xomx Thank you for your fix.
The new installers which contain the fix of crash in Safe Mode is available here for testing:
http://download.notepad-plus-plus.org/repository/MISC/fixSafeModeCrash/

@donho donho added the accepted Extra attention is needed label Oct 3, 2023
@donho donho closed this in b808b52 Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GurliGebis GurliGebis GurliGebis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@donho donho

Labels

accepted Extra attention is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Right click and selecting "Edit with Notepad++" causes Explorer.exe to crash when using Windows 11 Safe Mode

3 participants

@xomx @GurliGebis @donho