Skip to content

Some fixup to the parser and add test for potential failing route #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2022
Merged

Some fixup to the parser and add test for potential failing route #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa11313
Add test for path with dash
burbas Mar 6, 2022
a64c3b2
Fix the rules so it does not contain uneven shift/reduce
burbas Mar 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/routing_tree.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,12 @@ wildcard_binary_lookup_test() ->
Expected = {ok, #{}, "ONE", [<<"is">>, <<"amazing">>]},
?assertEqual(Expected, C).

dash_in_path_test() ->
A = new(#{convert_to_binary => true}),
B = insert('_', "/my-test-route", "GET", "ONE", A),
C = lookup(<<"My host">>, <<"/my-test-route">>, "GET", B),
Expected = {ok, #{}, "ONE"},
?assertEqual(Expected, C).



Expand Down
11 changes: 2 additions & 9 deletions src/routing_tree_parser.yrl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Nonterminals url_path path_segment query basic_element.
Nonterminals path_segment query basic_element.

Terminals 'divider' 'binding' 'wildcard' 'segment' 'query_start' 'ampersand' 'equals'.

Rootsymbol url_path.
Rootsymbol path_segment.


basic_element ->
Expand All @@ -26,11 +26,4 @@ path_segment ->
path_segment ->
'divider' basic_element path_segment: ['$2'|'$3'].

%% Remove trailing slash
url_path ->
path_segment 'divider': '$1'.
url_path ->
path_segment: '$1'.


Erlang code.