fix: code cleanup #6393
Merged
fix: code cleanup #6393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filter during the one iteration
don't filter just to iterate through the list again
No need to cast to an array and filter down to a second array
we can replace in the for loop instead
no need to iterate just to do that step and then iterate again
Unpack some ternaries Remove some impossible code Move some symbols to private attrs/methods
It distinguishes now between the #loadWorkspaces in lib/node.js
nlf
approved these changes
Apr 24, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly cleanups like moving to private methods, unpacking ternaries, removing places where lots of objects were being created just to spread back into object.create, and iterating trees once where it was being done multiple times previously.