Skip to content

Conversation

@TrevorBurnham
Copy link
Contributor

This commit updates npm-package-arg from v12.0.1 to v12.0.2. It also removes all usage of .replace(/#/g, '%23') for compatibility with the changes in npm/npm-package-arg#200.

I bumped the dependency using node ./scripts/resetdeps.js. The code changes are a simple find-and-replace: ".replace(/#/g, '%23')" -> "".

See:
npm/npm-package-arg#203

This commit updates npm-package-arg from v12.0.1 to v12.0.2. It also
removes all usage of `.replace(/#/g, '%23')` for compatibility with the
new version.

See:
npm/npm-package-arg#203
@wraithgar
Copy link
Member

We'll be making this PR ourselves. See https://github.com/npm/cli/blob/latest/CONTRIBUTING.md#dependencies

@wraithgar wraithgar closed this Feb 18, 2025
@wraithgar
Copy link
Member

Your work here is appreciated! It's just a security issue that we don't accept dependency updates in PRs for the cli itself since that code is vendored in. Our PR will credit you since it appears you did most of the work here already. Thank you.

wraithgar pushed a commit that referenced this pull request Feb 18, 2025
Removes all usage of `.replace(/#/g, '%23')` for compatibility with the new version

This is the code changes from #8112 isloated from the dependency update itself.

Closes:
npm/npm-package-arg#203

Credit: @TrevorBurnham
wraithgar pushed a commit that referenced this pull request Feb 18, 2025
Removes all usage of `.replace(/#/g, '%23')` for compatibility with the new version

This is the code changes from #8112 isloated from the dependency update itself.

Closes:
npm/npm-package-arg#203

Credit: @TrevorBurnham
wraithgar pushed a commit that referenced this pull request Feb 18, 2025
Removes all usage of `.replace(/#/g, '%23')` for compatibility with the new version

This is the code changes from #8112 isloated from the dependency update itself.

Closes:
npm/npm-package-arg#203

Credit: @TrevorBurnham
wraithgar pushed a commit that referenced this pull request Jun 23, 2025
Removes all usage of `.replace(/#/g, '%23')` for compatibility with the new version

This is the code changes from #8112 isloated from the dependency update itself.

Closes:
npm/npm-package-arg#203

Credit: @TrevorBurnham
wraithgar pushed a commit that referenced this pull request Jun 23, 2025
Removes all usage of `.replace(/#/g, '%23')` for compatibility with the new version

This is the code changes from #8112 isloated from the dependency update itself.

Closes:
npm/npm-package-arg#203

Credit: @TrevorBurnham
wraithgar pushed a commit that referenced this pull request Jun 23, 2025
Removes all usage of `.replace(/#/g, '%23')` for compatibility with the new version

This is the code changes from #8112 isloated from the dependency update itself.

Closes:
npm/npm-package-arg#203

Credit: @TrevorBurnham
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants