Skip to content

fix: spelling in workspaces/libnpmexec #8625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2025
+3 −3
Merged

fix: spelling in workspaces/libnpmexec #8625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71c258d
chore: Improve grammar: `; otherwise,`
jsoref Sep 28, 2025
2cba381
chore: fix spelling: cannot
jsoref Sep 28, 2025
2d278d3
chore: fix spelling: nonexistent
jsoref Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion workspaces/libnpmexec/lib/get-bin-from-manifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const getBinFromManifest = (mani) => {
// if we have a bin matching (unscoped portion of) packagename, use that
// otherwise if there's 1 bin or all bin value is the same (alias), use
// that, otherwise fail
// that; otherwise, fail
const bin = mani.bin || {}
if (new Set(Object.values(bin)).size === 1) {
return Object.keys(bin)[0]
Expand Down
2 changes: 1 addition & 1 deletion workspaces/libnpmexec/test/get-bin-from-manifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ t.test('extract scope from manifest name with multiple bins', t => {
t.end()
})

t.test('can not figure out what executable to run', t => {
t.test('cannot figure out what executable to run', t => {
t.throws(
() => getBinFromManifest({
name: 'lorem',
Expand Down
2 changes: 1 addition & 1 deletion workspaces/libnpmexec/test/local.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ t.test('bin in local pkg', async t => {
await chmod('node_modules/pkg-with-conflicting-bin/index.js')

// Note that we have to resetSeenLinks after each exec since otherwise
// our non-existent file will fail when it gets attempted to get chmod'ed
// our nonexistent file will fail when it gets attempted to get chmod'ed
// in a real world situation these would happen during different
// processes where these is no shared cache
const exec = async (...args) => {
Expand Down