Skip to content

fix: updates hints to use cli paradigm #8839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
owlstronaut merged 1 commit into from
Dec 9, 2025
Merged

fix: updates hints to use cli paradigm #8839

owlstronaut merged 1 commit into from
Dec 9, 2025
+12 −20

Conversation

@owlstronaut
Copy link
Contributor

@owlstronaut owlstronaut commented Dec 8, 2025 •
edited
Loading

The tests will need updating once #8838 merges done

@owlstronaut owlstronaut force-pushed the owlstronaut/split-params branch 3 times, most recently from 0e54172 to cf16f91 Compare December 9, 2025 17:40
@owlstronaut owlstronaut marked this pull request as ready for review December 9, 2025 17:47
@owlstronaut owlstronaut requested a review from a team as a code owner December 9, 2025 17:47
@wraithgar
Copy link
Member

wraithgar commented Dec 9, 2025

After discussion the fix is: just remove the hint on those config descriptions, they already follow the npm paradigm for arrays

$ node . config list --packages=asdf --packages=qwer

; "cli" config from command line options

packages = ["asdf","qwer"]

@owlstronaut owlstronaut force-pushed the owlstronaut/split-params branch from cf16f91 to 1185ded Compare December 9, 2025 18:42
@owlstronaut owlstronaut changed the title fix: updates params for token create to accept csv fix: updates hints to use cli paradigm Dec 9, 2025
@owlstronaut owlstronaut force-pushed the owlstronaut/split-params branch from 1185ded to 182442b Compare December 9, 2025 18:47
wraithgar
wraithgar reviewed Dec 9, 2025
View reviewed changes
@owlstronaut owlstronaut force-pushed the owlstronaut/split-params branch from 182442b to 9f36e9c Compare December 9, 2025 18:54
@owlstronaut owlstronaut requested a review from wraithgar December 9, 2025 18:55
@owlstronaut owlstronaut merged commit 4ebb831 into latest Dec 9, 2025
33 checks passed
@owlstronaut owlstronaut deleted the owlstronaut/split-params branch December 9, 2025 19:10
@github-actions github-actions bot mentioned this pull request Dec 9, 2025
Merged
@npm-cli-bot npm-cli-bot mentioned this pull request Dec 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@owlstronaut @wraithgar