-
Notifications
You must be signed in to change notification settings - Fork 243
[nrf noup] bootutil: loader: Add check for netcore addr if NSIB enabled #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrf noup] bootutil: loader: Add check for netcore addr if NSIB enabled #202
Conversation
|
The commit message needs a fix otherwise the code looks good. Add a title to the commit in the form of [nrf noup] bootutil: loader: Add check for network core address when NSIB is enabled (maybe this title is too long) Content should be something like: This enables network core updates when NSIB and MCUBoot are enabled. Ref. NCSIDB-696 Also remember to sign your commits with Try to have similar formatting as shown here e7db825 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is okei, commit message needs a fixup.
060c83d to
0334f6a
Compare
|
Does it look good now?
One time has to be the first. It's nice to go through this and learn how it's done. |
0334f6a to
1dd9ced
Compare
| reset_addr = vtable[1]; | ||
| #ifdef PM_S1_ADDRESS | ||
| const struct flash_area *primary_fa; | ||
| int rc = flash_area_open(flash_area_id_from_multi_image_slot( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would work for the network image pair, but its primary slot is emulated in RAM, therefore the flash_area doesn't have real offset.
|
@simon-iversen Can you open manifest PR ASAP? |
1dd9ced to
299e29e
Compare
|
299e29e to
7922381
Compare
Add check for netcore addr if NSIB is enabled so netcore updates works Ref. NCSIDB-696 Signed-off-by: Simon Iversen <simon.iversen@nordicsemi.no>
7922381 to
c23f293
Compare
Adds check for network core addresses when NSIB(Nordic Secure Immutable Bootlaoder) is enabled, so that network core updates still will work.
Ref. NCSIDB-696