Skip to content

applications: sdp: mspi: extend MSPI API with reset functions #21076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

applications: sdp: mspi: extend MSPI API with reset functions #21076

wants to merge 3 commits into from

Conversation

@magp-nordic
Copy link
Contributor

@magp-nordic magp-nordic commented Mar 20, 2025 •
edited
Loading

Extend MSPI API with custom functions handling reset pins.

Needs changes from #20870 (d033f90 commit) #21205, otherwise stack overflow in ICMsg happens. (merged)

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 20, 2025
@magp-nordic magp-nordic mentioned this pull request Mar 20, 2025
Closed
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 20, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 8

Inputs:

Sources:

sdk-nrf: PR head: 49ed243cc6b9ff8df9a33d96ee564ef25c04c606

more details

sdk-nrf:

PR head: 49ed243cc6b9ff8df9a33d96ee564ef25c04c606
merge base: f9474f069603018f4b8d09a38d19af1e12248ce4
target head (main): 4a662ee237365bd35cf8f140a4706d84121259d3
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (7) 
CODEOWNERS
applications
│  ├── sdp
│  │  ├── mspi
│  │  │  ├── src
│  │  │  │  ├── hrt
│  │  │  │  │  ├── hrt-nrf54l15.s
│  │  │  │  │  │ hrt.c
│  │  │  │  │ main.c
drivers
│  ├── mspi
│  │  │ mspi_nrfe.c
include
│  ├── drivers
│  │  ├── mspi
│  │  │  ├── nrf_mspi.h
│  │  │  │ nrfe_mspi.h

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 42
  • ✅ Integration tests
    • ✅ test-low-level
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@magp-nordic magp-nordic force-pushed the NRFX-7213-handle-reset-gpios-property branch from 3022645 to 98eb5fc Compare March 26, 2025 12:10
@magp-nordic
applications: sdp: mspi: fix setting previous state of pins in RX
df76e1b 
Fix setting previous state of not used pins in RX path.

Signed-off-by: Magdalena Pastula <magdalena.pastula@nordicsemi.no>
@magp-nordic
applications: sdp: mspi: extend MSPI API with reset functions
c2daec3 
Extend MSPI API with custom functions handling reset pins.

Signed-off-by: Magdalena Pastula <magdalena.pastula@nordicsemi.no>
@magp-nordic magp-nordic force-pushed the NRFX-7213-handle-reset-gpios-property branch from 796f200 to 3b18859 Compare March 27, 2025 18:50
@magp-nordic magp-nordic marked this pull request as ready for review March 27, 2025 18:52
@magp-nordic magp-nordic requested review from a team as code owners March 27, 2025 18:52
@magp-nordic magp-nordic force-pushed the NRFX-7213-handle-reset-gpios-property branch from 3b18859 to c4e432b Compare March 27, 2025 18:54
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 27, 2025
@magp-nordic magp-nordic force-pushed the NRFX-7213-handle-reset-gpios-property branch 2 times, most recently from 957e5f1 to ce74520 Compare March 27, 2025 19:08
@magp-nordic
applications: sdp: mspi: change opcode cast to uint32
49ed243 
Change cast of opcode in ep_recv function to uint32_t instead
of uint8_t.

Signed-off-by: Magdalena Pastula <magdalena.pastula@nordicsemi.no>
@magp-nordic magp-nordic force-pushed the NRFX-7213-handle-reset-gpios-property branch from ce74520 to 49ed243 Compare March 28, 2025 08:29
@github-actions
Copy link

You can find the documentation preview for this PR here.

masz-nordic
masz-nordic reviewed Mar 31, 2025
View reviewed changes
include/drivers/mspi/nrf_mspi.h

/**
* @brief Configure reset pin. It should be used if there is a chance that reset pin overlaps with
* any data pin.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* any data pin.
* any data pin and the pin cannot be driven using the GPIO driver.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same below

include/drivers/mspi/nrf_mspi.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be added as nrf_mspi_nrfe.h and handled like here:
zephyrproject-rtos/zephyr@d15c9fe#diff-d885f38f08e1f9834b82662415584d86d30ebe27189a3df3530e4f359c75fdd5

applications/sdp/mspi/src/hrt/hrt.c

/* Get state of all VIO to reset it correctly after transfer. */
prev_out = nrf_vpr_csr_vio_out_get();
prev_out = nrf_vpr_csr_vio_out_get() >> 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment why it is needed.

@magp-nordic magp-nordic added this to the 3.0.0 milestone Mar 31, 2025
@magp-nordic
Copy link
Contributor Author

Closing, after discussion with @anangl we came to the conclusion that these changes are not needed, since reset gpio defined in dts should not overlay if any MSPI data pin. If it does, it should be handled internally in MSPI driver as pull-up or holding high state until QUAD mode is enabled in flash, which is the current solution in SDP MSPI.

@magp-nordic magp-nordic closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masz-nordic masz-nordic masz-nordic left review comments

@jaz1-nordic jaz1-nordic Awaiting requested review from jaz1-nordic

@mif1-nordic mif1-nordic Awaiting requested review from mif1-nordic

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@magp-nordic @NordicBuilder @masz-nordic