Skip to content

Conversation

zycz
Copy link
Contributor

@zycz zycz commented Jun 25, 2024

Turn on NRFS globaly so turning off
suspending MRAM for NRF54H20 DK will work.

@zycz zycz force-pushed the turn_on_globaly_nrfs branch from f6ad38b to 990f9e9 Compare June 25, 2024 12:43
@zycz zycz requested review from pdunaj and tomchy June 25, 2024 12:44
@zycz
Copy link
Contributor Author

zycz commented Jun 25, 2024

Need to disable NRFS when MISRA_SANE is on - IPC uses variable length array -which is unacceptable with MISRA_SANE on.

@anangl
Copy link
Contributor

anangl commented Jun 25, 2024

Please add nrf-squash! [nrf noup] boards: nordic: Turn off MRAM suspend for NRF54H20 DK at the top of the commit message.

@zycz zycz force-pushed the turn_on_globaly_nrfs branch from 990f9e9 to 66a97e3 Compare June 25, 2024 13:04
@zycz
Copy link
Contributor Author

zycz commented Jun 25, 2024

Please add nrf-squash! [nrf noup] boards: nordic: Turn off MRAM suspend for NRF54H20 DK at the top of the commit message.

done

@anangl
Copy link
Contributor

anangl commented Jun 25, 2024

Please add nrf-squash! [nrf noup] boards: nordic: Turn off MRAM suspend for NRF54H20 DK at the top of the commit message.

done

Sorry for being a bit imprecise. This line should be the first one in the body of the commit message, not its title. Just swap it with [nrf noup] boards: nordic: Turn on NRFS globally, please.

nrf-squash! [nrf noup] boards: nordic: Turn off MRAM suspend for NRF54H20 DK
Turn on NRFS globally so turning off
suspending MRAM for NRF54H20 DK will work.

Signed-off-by: Jan Zyczkowski <jan.zyczkowski@nordicsemi.no>
@zycz zycz force-pushed the turn_on_globaly_nrfs branch from 66a97e3 to edb4afa Compare June 25, 2024 13:10
Copy link

@shanthanordic shanthanordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as the soln was agreed. sdk-nrf PR was approved by stakeholders

@anangl anangl merged commit 9b6cae8 into nrfconnect:main Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants