[nrf noup] sysbuild: Support for ED25519 with SHA512 and PureEdDSA #2229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
requested changes
Nov 6, 2024
Comment on lines
41
to
51
| set(imgtool_extra_args "${CONFIG_MCUBOOT_EXTRA_IMGTOOL_ARGS}") | ||
| if(SB_CONFIG_BOOT_SIGNATURE_TYPE_ED25519) | ||
| if(SB_CONFIG_BOOT_SIGNATURE_TYPE_PURE) | ||
| string(APPEND imgtool_extra_args " --pure") | ||
| else() | ||
| string(APPEND imgtool_extra_args " --sha 512") | ||
| endif() | ||
| endif() | ||
|
|
There was a problem hiding this comment.
this should not be in sdk-zephyr at all, move it to sdk-nrf, as part of sysbuild, and set Kconfigs in the image which then enable these options, do not use the extra args - that field is for users to change as they want
Commit adds sysbuild support for setting ED25519 signature type for application image and Pure modifier, to the signature, that allows to indicate that signature will be calculated over an entire image, rather than hash of the image. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic
force-pushed
the
mcuboot-sb-psa-conf
branch
from
9288a34 to
74c69c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit adds imgtool parameters that allow to sign image with SHA512, for ED25519, or use PureEdDSA variant, where signature is calculated over entire image rather than SHA of that image.