Skip to content

[nrf fromlist] boards: nordic: nrf54h20dk: Fix FLASH_LOAD_SIZE #3001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nordic-mik7 wants to merge 1 commit into from
Closed

[nrf fromlist] boards: nordic: nrf54h20dk: Fix FLASH_LOAD_SIZE #3001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions boards/nordic/nrf54h20dk/Kconfig.defconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Copyright (c) 2024 Nordic Semiconductor ASA
# SPDX-License-Identifier: Apache-2.0

# Workaround for not being able to have commas in macro arguments
DT_CHOSEN_Z_CODE_PARTITION := zephyr,code-partition

if BOARD_NRF54H20DK_NRF54H20_CPUAPP

config BT_HCI_IPC
Expand All @@ -26,6 +29,9 @@ config ROM_START_OFFSET
config FLASH_LOAD_OFFSET
default 0x30000 if !USE_DT_CODE_PARTITION

config FLASH_LOAD_SIZE
default $(dt_chosen_reg_size_hex,$(DT_CHOSEN_Z_CODE_PARTITION)) if !USE_DT_CODE_PARTITION
Copy link
Contributor

@ahasztag ahasztag Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem the right approach, rather a fixed value should be used.

I do not thing that anything from zephyr,code-partition should be used if !USE_DT_CODE_PARTITION

Let's say you have flash start at 2c000, and zephyr-code-partition and 3c000 - than the zephyr-code-partition would be smaller than the actual available size

Copy link
Contributor Author

@nordic-mik7 nordic-mik7 Jun 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't FLASH_LOAD_SIZE indicate the code parition in fact ? why should we include the rest of available flash in it ?


endif # BOARD_NRF54H20DK_NRF54H20_CPUAPP_IRON

if BOARD_NRF54H20DK_NRF54H20_CPURAD_IRON
Expand Down
Loading