Skip to content

Feature/ident literally #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 27, 2023
Merged

Feature/ident literally #63

merged 3 commits into from
Apr 27, 2023

Conversation

@ingarabr
Copy link
Contributor

@ingarabr ingarabr commented Apr 27, 2023 •
edited
Loading

Add compile time validation of valid idents. This is a minimal effort and can be improved on later.

Migration:

  • Add the import: no.nrk.bigquery.syntax._
  • Replace Ident("my_value") with ident"my_value"

Example usage:

import no.nrk.bigquery.syntax._

val validIdent1 = ident"foo" // compiles
val validIdent2 = ident"foo.bar" // compiles
val invalidIdent = ident"4foos" // compile error

ingarabr added 3 commits April 27, 2023 10:42
@ingarabr
feat(core): compile time validation of Ident
3cf607f
@ingarabr
fix(core): do not use ident in mkFragment
f8aeea3 
It's not expected that the strings we use should follow the
indent rules when it comes to how they crate BQ fragments.
@ingarabr
refactor: use new ident syntax
6363de2
@ingarabr ingarabr marked this pull request as ready for review April 27, 2023 08:56
@ingarabr ingarabr mentioned this pull request Apr 27, 2023
Closed
8 tasks
hamnis
hamnis reviewed Apr 27, 2023
View reviewed changes
core/src/main/scala-2/no/nrk/bigquery/syntax.scala

import org.typelevel.literally.Literally

object syntax {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow-up PR with moving interpolators and other syntax instances here.

@ingarabr ingarabr merged commit 1661ac5 into main Apr 27, 2023
@ingarabr ingarabr deleted the feature/ident-literally branch April 27, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HenningKoller HenningKoller Awaiting requested review from HenningKoller

1 more reviewer

@hamnis hamnis hamnis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ingarabr @hamnis