fix: traverse inner udf body first #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingarabr
commented
May 11, 2023
| case BQSqlFrag.Call(udf, _) => | ||
| udf match { | ||
| case UDF.Temporary(_, _, UDF.Body.Sql(body), _) => Some(body) | ||
| case UDF.Persistent(_, _, UDF.Body.Sql(body), _) => Some(body) // todo: should this be None? |
There was a problem hiding this comment.
For temporary functions it make sense to traverse the body. I do not see a reason for doing it for persistent functions. If we need to tap into them, then we can collect all the UDFs and call collect on the inner body element.
hamnis
approved these changes
May 11, 2023
We inline temporary UDFs and we need to traverse the body to include other temporary UDFs that are referenced. We need to do this first since they need to be crated in the right order.
Fixed traversing in the previous commit.
ingarabr
force-pushed
the
fix/traversing-bg-frag
branch
from
bdfd846 to
d28d657
Compare
hamnis
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When traversing bq-frag in collect we should first evaluate the inner udf bodies.