Skip to content

Conversation

@aminya
Copy link

@aminya aminya commented Mar 8, 2025

This updates the freetype dependency to freetype2. All the changes from the fork have been merged and new fixes have been added.

About the Contributor

Personal contribution

Type of Contribution

Dependency update

Current Behavior

New Behavior

Testing Instructions

The current tests should pass

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@nytamin nytamin self-requested a review April 14, 2025 08:42
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.62%. Comparing base (b0c706f) to head (981fb9d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   83.62%   83.62%           
=======================================
  Files         191      191           
  Lines        6057     6057           
  Branches      999      907   -92     
=======================================
  Hits         5065     5065           
  Misses        992      992           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nytamin
Copy link
Member

nytamin commented Apr 14, 2025

I've checked a bit with the team, and I'm leaning towards keeping the existing dependency.

It seems like there are a few issues in the official package related to it's usage of node-gyp and node-addon-api, as those dependencies are too new for node 14 (as reported in their engines), so merging this probably should be a semver major change (or reported as a bug, the package does claim to support 14).

Is there any particular issue you'd like to resolve with changing the dependency to the official one?

@nytamin nytamin closed this Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants