fix(misc): allow run-commands to accept readyWhen for a single command (#6496)

Author: leosvelperez

docs/angular/api-workspace/executors/run-commands.md

@@ -222,4 +222,4 @@ Run commands in parallel
 
 Type: `string`
 
-String to appear in `stdout` or `stderr` that indicates that the task is done. This option can only be used when multiple commands are run and `parallel` is set to `true`. If not specified, the task is done when all the child processes complete.
+String to appear in `stdout` or `stderr` that indicates that the task is done. When running multiple commands, this option can only be used when `parallel` is set to `true`. If not specified, the task is done when all the child processes complete.

docs/node/api-workspace/executors/run-commands.md

@@ -223,4 +223,4 @@ Run commands in parallel
 
 Type: `string`
 
-String to appear in `stdout` or `stderr` that indicates that the task is done. This option can only be used when multiple commands are run and `parallel` is set to `true`. If not specified, the task is done when all the child processes complete.
+String to appear in `stdout` or `stderr` that indicates that the task is done. When running multiple commands, this option can only be used when `parallel` is set to `true`. If not specified, the task is done when all the child processes complete.

docs/react/api-workspace/executors/run-commands.md

@@ -223,4 +223,4 @@ Run commands in parallel
 
 Type: `string`
 
-String to appear in `stdout` or `stderr` that indicates that the task is done. This option can only be used when multiple commands are run and `parallel` is set to `true`. If not specified, the task is done when all the child processes complete.
+String to appear in `stdout` or `stderr` that indicates that the task is done. When running multiple commands, this option can only be used when `parallel` is set to `true`. If not specified, the task is done when all the child processes complete.

packages/workspace/src/executors/run-commands/run-commands.impl.spec.ts

@@ -194,36 +194,6 @@ describe('Command Runner Builder', () => {
   });
 
   describe('readyWhen', () => {
-    it('should warn when command is specified instead of commands', async () => {
-      jest.spyOn(process.stderr, 'write');
-      await runCommands(
-        {
-          command: `echo 'Hello World'`,
-          readyWhen: 'READY',
-        },
-        context
-      );
-
-      expect(process.stderr.write).toHaveBeenCalledWith(
-        'Warning: "readyWhen" has no effect when a single command is run. The task will be done when the command process is completed. Ignoring.'
-      );
-    });
-
-    it('should warn when a single command is specified', async () => {
-      jest.spyOn(process.stderr, 'write');
-      await runCommands(
-        {
-          commands: [`echo 'Hello World'`],
-          readyWhen: 'READY',
-        },
-        context
-      );
-
-      expect(process.stderr.write).toHaveBeenCalledWith(
-        'Warning: "readyWhen" has no effect when a single command is run. The task will be done when the command process is completed. Ignoring.'
-      );
-    });
-
     it('should error when parallel = false', async () => {
       try {
         await runCommands(
@@ -237,7 +207,7 @@ describe('Command Runner Builder', () => {
         fail('should throw');
       } catch (e) {
         expect(e.message).toEqual(
-          `ERROR: Bad builder config for @nrwl/run-commands - "readyWhen" can only be used when parallel=true.`
+          `ERROR: Bad executor config for @nrwl/run-commands - "readyWhen" can only be used when "parallel=true".`
         );
       }
     });

packages/workspace/src/executors/run-commands/run-commands.impl.ts

@@ -71,15 +71,9 @@ export default async function (
   const normalized = normalizeOptions(options);
 
   if (options.readyWhen && !options.parallel) {
-    if (options.command || options.commands?.length === 1) {
-      process.stderr.write(
-        'Warning: "readyWhen" has no effect when a single command is run. The task will be done when the command process is completed. Ignoring.'
-      );
-    } else {
-      throw new Error(
-        'ERROR: Bad builder config for @nrwl/run-commands - "readyWhen" can only be used when parallel=true.'
-      );
-    }
+    throw new Error(
+      'ERROR: Bad executor config for @nrwl/run-commands - "readyWhen" can only be used when "parallel=true".'
+    );
   }
 
   try {
@@ -146,14 +140,11 @@ function normalizeOptions(
 
   if (options.command) {
     options.commands = [{ command: options.command }];
-    options.parallel = false;
+    options.parallel = !!options.readyWhen;
   } else {
     options.commands = options.commands.map((c) =>
       typeof c === 'string' ? { command: c } : c
     );
-    if (options.commands.length === 1) {
-      options.parallel = false;
-    }
   }
   (options as NormalizedRunCommandsBuilderOptions).commands.forEach((c) => {
     c.command = transformCommand(

packages/workspace/src/executors/run-commands/schema.json

@@ -46,7 +46,7 @@
     },
     "readyWhen": {
       "type": "string",
-      "description": "String to appear in `stdout` or `stderr` that indicates that the task is done. This option can only be used when multiple commands are run and `parallel` is set to `true`. If not specified, the task is done when all the child processes complete."
+      "description": "String to appear in `stdout` or `stderr` that indicates that the task is done. When running multiple commands, this option can only be used when `parallel` is set to `true`. If not specified, the task is done when all the child processes complete."
     },
     "args": {
       "type": "string",