relax sorting rules #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 13, 2017 23:48
…alling `npm test` - Add vscode configuration, for easy unit tests debugging - be case agnostic for connection string keys (Both `User ID` and `User Id` should work). - if a user has no @ assume that the entire value is the user id. (required removal of one unit test).
Contributor
|
Thanks for improvements. |
Contributor
Author
|
@jczas would it be possible to release version 0.0.5? |
Contributor
|
@izikl done |
Contributor
Author
|
@jczas ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not a 100% match for this repository, since I am not using it as an input for knex but just as a parser for mssql connection strings, but I think it will be nice to make it more generic.
changes:
User IDandUser Idshould work).In Azure App Service for example, The connection string that is generated by Azure contains
User IDwith capital D.@in the user id is not required, if it doesn't exist return the entire user instead of throwing.npm installfirst before callingnpm test