Allow missing protocol and port #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you very much for improvement ;) |
Contributor
Author
|
@jczas You're very welcome! And thank you for this useful code! Will this change be published to npm automatically? |
Contributor
|
I'll publish it to npm next week. This week I'm on vacation and have only my mobile phone. ;) |
Contributor
|
I've published the new version 0.0.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I needed to allow for missing protocol and port numbers in my connectionstring, so I refined the parsing of the
data sourceresult a bit. It only adds theportto the result config object if it is found. Also added some tests to illustrate the changes.