Skip to content

Conversation

@johsoe
Copy link
Contributor

@johsoe johsoe commented Nov 5, 2021

Due to a recent discovery in that MaterialApp.router() exposes a builder: method where the BuildContext has initialised Localizations etc, we can put in NStack there and "go back" to the simpler approach.

We also wrap our internal NStackScope widget in a FutureBuilder that awaits minor state loading, such as overwritten locale or other stuff further down the line.

@johsoe johsoe requested a review from markusrubey November 7, 2021 20:34
@markusrubey markusrubey merged commit b4f4e95 into master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants