Fix GPU crash when setting cover from downloaded chapters. #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes null2264#368 Prevent segmentation fault by applying size constraints during bitmap decode instead of after. Large downloaded chapter images were causing GPU memory overflow before size validation. - Add pre-decode size check using inJustDecodeBounds - Implement calculateInSampleSize to downsample large images during decode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #368
Fixes a segmentation fault that occurs when using "Set as Cover" from the reader context menu on downloaded chapters.
The crash , caused by GPU memory overflow, happens in RenderThread and affects both physical devices and Android emulator.
setCustomCoverToCache()to analyze image dimensions before decodecalculateInSampleSize()helper to downsample large images