Start and stop Async reads on console out at will #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose `CancelAsyncReads` that will break the `StreamReader.ReadAsync` blocking in a thread at will. `StreamReader.ReadAsync` does not expose a cancellationtoken even if the underlying `Stream.ReadAsync` does. If you are no longer interested in the console output you can now call `CancelAsyncReads` to break out of the possibly blocking `StreamReader.ReadAsync` calls. Doing this will leave the launched process running. and `StartAsyncReads` allows you to resubscribe again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
CancelAsyncReadsthat will break theStreamReader.ReadAsyncblocking in a thread at will.StreamReader.ReadAsyncdoes not expose a cancellationtoken even if theunderlying
Stream.ReadAsyncdoes. If you are no longer interested inthe console output you can now call
CancelAsyncReadsto break out ofthe possibly blocking
StreamReader.ReadAsynccalls. Doing this willleave the launched process running.
and
StartAsyncReadsallows you to resubscribe again.cc @codebrain @russcam