Merged
Conversation
1. version requirements are what you set 2. versions are what you install
nwayve
reviewed
Oct 18, 2016
README.md
Outdated
| > nodist npm 3.x | ||
| # Globally activate npm 3 | ||
| > nodist global npm 3.x | ||
| # Set global node version requirement. |
There was a problem hiding this comment.
Should this be
"Sets the global npm version requirement."
nwayve
reviewed
Oct 18, 2016
usage.txt
Outdated
| nodist run <version> -- <args..> Run <args> with the specified node version | ||
| nodist r <version> -- <args..> (downloads the executable, if necessary). | ||
| nodist run <ver-req> -- <args> Run <args> with a version matching the provided requirement. | ||
| nodist r <ver-req> -- <args> (Will abort if no matching version is installed) |
There was a problem hiding this comment.
I would either lowercase "Will" or capitalize the first word in the subsequent parentheticals. Also missing period here and on line 40.
|
Some minor details in the usage.txt but overall I think these are good updates to the docs. |
|
👍 |
Member
Author
|
Thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #172
please provide feedback! :)