fix(security): resolve cluster SG from data source instead of variable#284
Merged
agustincelentano merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
The cluster_security_group_id variable was used in count expressions, but on first apply its value is (known after apply) causing plan failures. Now the module derives the SG internally from data.aws_eks_cluster when the variable is not provided, using the same override pattern as vpc_id and network_cidr.
gdrojas
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
cluster_security_group_idvariable was used incountexpressions, but on first apply when EKS doesn't exist yet, its value is(known after apply)and OpenTofu can't evaluate the count during plan.Now the module derives the primary SG internally from
data.aws_eks_cluster.this[0].vpc_config[0].cluster_security_group_id(which resolves viadepends_on), using the same override pattern asvpc_idandnetwork_cidr:cluster_security_group_idvariable is provided -> use it (override)This eliminates the need for a second
tofu applyon fresh setups.Test plan
cluster_security_group_id— verify override still works