fix(nullplatform): add dimensions variable and eks balancer improvements#290
Merged
fix(nullplatform): add dimensions variable and eks balancer improvements#290
Conversation
- Replace hardcoded dimensions = {} with var.dimensions in ecr, docker_server,
code_repository, and cloud/aws/cloud
- Add dimensions variable (default = {}) to ecr, docker_server, code_repository
- Add alb_capacity_threshold, additional_public_balancer_names,
additional_private_balancer_names to eks module
- Refactor eks balancer local to use merge() for optional fields
gdrojas
force-pushed
the
fix/dimensions-variable-and-eks-balancer
branch
from
0e73d11 to
475ba60
Compare
agustincelentano
approved these changes
Apr 16, 2026
… constraints - Add range validation (50-99) to alb_capacity_threshold - Add AWS ALB naming validation to additional_public_balancer_names and additional_private_balancer_names (1-32 chars, alphanumeric and hyphens, cannot start or end with a hyphen)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dimensions = {}withvar.dimensionsinasset/ecr,asset/docker_server,code_repository, andcloud/aws/cloudmodulesdimensionsvariable withdefault = {}toecr,docker_server, andcode_repositorymodules for consistencyalb_capacity_threshold,additional_public_balancer_names, andadditional_private_balancer_namesvariables toeksmodule to support deployments beyond the 100-rule ALB limiteksbalancer local to usemerge()for optional field inclusion