Skip to content

feat(scope_configuration): support icon#348

Merged
agustincelentano merged 1 commit into
mainfrom
feat/scope-configuration-icon-release-fix
May 12, 2026
Merged

feat(scope_configuration): support icon#348
agustincelentano merged 1 commit into
mainfrom
feat/scope-configuration-icon-release-fix

Conversation

@agustincelentano

Copy link
Copy Markdown
Collaborator

Summary

Re-triggers release-please for the change merged in #336.

Context

PR #336 (Support icon in scope configuration) was merged with a non-conventional title. Since the repo uses squash merge, the PR title becomes the only commit message on main, and release-please parses commits on main to decide what enters the next release. As a result, the feat was skipped across releases 2.4.0 → 2.4.3.

The actual code change is already in main at commit a8fea94. This PR contains an empty commit whose subject follows Conventional Commits, so release-please can recognize the change and include it in the next release PR (bumps minor → 2.5.0).

Why an empty commit

  • The code is already merged; there is nothing to re-apply.
  • An empty commit with a conventional subject is the standard way to surface a missed change to release-please without re-doing the merge or rewriting history on main.

Follow-up (optional)

Consider adding a PR title validator (e.g. amannn/action-semantic-pull-request) so future PR titles are enforced — the existing commitlint workflow only validates commits, not the PR title that survives the squash.

Test plan

  • Empty commit subject matches feat(scope): description per @commitlint/config-conventional.
  • After merge, release-please opens / updates a release PR including this feat.

Re-triggers release-please for changes merged in #336, which used a
non-conventional PR title ("Support icon in scope configuration") and
was therefore skipped by release-please when generating 2.4.0..2.4.3.

The functional change is already in main (a8fea94); this empty commit
exists only so release-please picks up the feat in the next release.
@agustincelentano agustincelentano merged commit a4db9cf into main May 12, 2026
40 checks passed
@agustincelentano agustincelentano deleted the feat/scope-configuration-icon-release-fix branch May 12, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant