feat(base): agregar gateway_public_azure_load_balancer_subnet#403
Merged
sebastiancorrea81 merged 1 commit intoJun 25, 2026
Merged
Conversation
Wire a subnet name through to the public gateway's internal Azure load balancer. The chart consumes it as gateway.public.azure.subnet and emits service.beta.kubernetes.io/azure-load-balancer-internal-subnet only when set. Only meaningful when gateway_public_load_balancer_type is 'internal'; empty by default, so existing setups keep letting Azure pick the subnet automatically. Mirrors internal_azure_load_balancer_subnet for the private gateway.
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Agrega la variable
gateway_public_azure_load_balancer_subnetal módulonullplatform/base, que se cablea hacia el gateway público comogateway.public.azure.subneten los values del chart.Es el espejo de
internal_azure_load_balancer_subnet(que ya existe para el gateway privado).Por qué
Cuando el gateway público se despliega con
gateway_public_load_balancer_type = "internal"(tráfico que entra por una vía privada — túnel/proxy en la VNet), hoy no hay forma de fijar el LB interno a una subnet específica desde el módulo. Azure elige la subnet automáticamente. Esto obliga a parchear con unkubernetes_annotationsexterno.Cambios
variables.tf: nueva variablegateway_public_azure_load_balancer_subnet(string, default"").locals.tf: mapeo al valor del templategateway_public_azure_load_balancer_subnet.templates/nullplatform_base_values.tmpl.yaml: emitesubnetdentro del bloquepublic.azure(simétrico a cómo OCI anida su subnet bajopublic.oci).tests/base_values.tftest.hcl: nuevo test que verifica que el valor se renderiza.Retrocompatibilidad
Default vacío → comportamiento sin cambios (Azure elige la subnet). La anotación en el chart solo se emite cuando el valor está seteado.
Verificación
(incluye el nuevo
gateway_public_azure_load_balancer_subnet)