Skip to content

Conversation

@mvllow
Copy link
Contributor

@mvllow mvllow commented Feb 15, 2022

includes fennel, lisp and scheme filetypes

@numToStr
Copy link
Owner

numToStr commented Feb 15, 2022

Does lisp comments starts with one semicolon? Although I have also seen two semicolon like in treesitter queries.

(I am not a lisp guy, so i might be missing something)

@mvllow
Copy link
Contributor Author

mvllow commented Feb 15, 2022

didn't even think of that, i saw ; worked but you're right, ;; is the proper convention when commenting code 😌

@numToStr
Copy link
Owner

Noice. Also can you check the filetype for treesitter queries? We can also add that if it's different from lisp.

includes fennel, lisp and scheme filetypes
@numToStr
Copy link
Owner

numToStr commented Feb 15, 2022

@mvllow I did a quick read and I think lisp and scheme also supports block comments.

From scheme docs:

Block comments are delimited by #| and |# pairs, and may be nested.

@mvllow
Copy link
Contributor Author

mvllow commented Feb 15, 2022

added block comments to lisp and scheme. fennel doesn't seem to have block comments

@mvllow
Copy link
Contributor Author

mvllow commented Feb 15, 2022

clojure may have the same lisp comments as well, although i haven't tried it – didn't realise how many lisp-based languages there were

@mvllow
Copy link
Contributor Author

mvllow commented Feb 16, 2022

built-in clojure's commentstring is ;. should we override that to match ;;? still seems like ;; is more conventional – although ; works for all of the mentioned lisp languages

@numToStr
Copy link
Owner

For now I think it's ok. We can add closure in a separate PR or if someone complains about it :)

@numToStr numToStr merged commit 18a8dc0 into numToStr:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants