Skip to content

Conversation

kohlisid
Copy link
Contributor

@kohlisid kohlisid commented Oct 7, 2024

Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.28%. Comparing base (b1b2d94) to head (eb03233).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...numaflow/reducestreamer/servicer/async_servicer.py 50.00% 2 Missing ⚠️
pynumaflow/shared/thread_with_return.py 90.90% 0 Missing and 1 partial ⚠️
pynumaflow/sinker/servicer/async_servicer.py 96.77% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   94.04%   94.28%   +0.23%     
==========================================
  Files          54       56       +2     
  Lines        2167     2222      +55     
  Branches      131      141      +10     
==========================================
+ Hits         2038     2095      +57     
+ Misses         97       93       -4     
- Partials       32       34       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
@kohlisid kohlisid changed the title [WIP]chore: streaming sink chore: streaming sink Oct 9, 2024
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
@kohlisid kohlisid changed the title chore: streaming sink [WIP] chore: streaming sink Oct 16, 2024
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
@kohlisid kohlisid changed the title [WIP] chore: streaming sink chore: streaming sink Oct 17, 2024
@kohlisid kohlisid changed the title chore: streaming sink feat: streaming sink Oct 17, 2024
@kohlisid kohlisid marked this pull request as ready for review October 17, 2024 23:20
@kohlisid kohlisid requested a review from KeranYang October 17, 2024 23:20
@KeranYang KeranYang requested a review from yhl25 October 17, 2024 23:29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is used only in the sync path, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Copy link
Member

@KeranYang KeranYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with nit comments.

Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
@kohlisid kohlisid requested a review from ab93 October 18, 2024 20:22
@kohlisid kohlisid merged commit ec00728 into numaproj:main Oct 18, 2024
11 checks passed
@kohlisid kohlisid deleted the ss-sink branch October 18, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python SDK for Streaming Sink

4 participants