-
Notifications
You must be signed in to change notification settings - Fork 24
feat: streaming sink #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: streaming sink #193
Conversation
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
==========================================
+ Coverage 94.04% 94.28% +0.23%
==========================================
Files 54 56 +2
Lines 2167 2222 +55
Branches 131 141 +10
==========================================
+ Hits 2038 2095 +57
+ Misses 97 93 -4
- Partials 32 34 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is used only in the sync path, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with nit comments.
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Resolves: numaproj/numaflow#2097