Skip to content

Conversation

@BulkBeing
Copy link
Contributor

@BulkBeing BulkBeing commented Oct 18, 2025

#257

The image builds were tested in an older commit without pushing images (https://github.com/numaproj/numaflow-python/actions/runs/18615039840)

The Readme.md (referenced in pyproject.toml) and LICENSE is copied to packages/pynumaflow so that they will be included in the source/wheel distribution.

Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.53%. Comparing base (321942d) to head (4ae1a16).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   93.63%   93.53%   -0.11%     
==========================================
  Files          65       65              
  Lines        2907     2907              
  Branches      152      152              
==========================================
- Hits         2722     2719       -3     
- Misses        135      138       +3     
  Partials       50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@BulkBeing BulkBeing marked this pull request as ready for review October 18, 2025 13:23
@vigith vigith requested a review from kohlisid October 18, 2025 15:02
@@ -0,0 +1,163 @@
# Python SDK for Numaflow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just move the Readme rather than copy?

@vigith
Copy link
Member

vigith commented Oct 18, 2025

for pyproject.toml, can we give relative path for the the LICENSE?

@kohlisid
Copy link
Contributor

@vigith we're thinking for unified releases or seperate wheels?

@vigith
Copy link
Member

vigith commented Oct 18, 2025

@vigith we're thinking for unified releases or seperate wheels?

separate wheels

Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@BulkBeing
Copy link
Contributor Author

for pyproject.toml, can we give relative path for the the LICENSE?

$ poetry build
Invalid entry in [project.license-files]: '../../LICENSE' ('..' must not be used.)

Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
@vigith vigith changed the title Rearrange code to support both existing and new Rust FFI based pynumaflow chore: Rearrange code to support both existing and new Rust FFI based pynumaflow Oct 19, 2025
@vigith vigith merged commit 40cbff8 into main Oct 19, 2025
12 checks passed
@vigith vigith deleted the multiple-packages branch October 19, 2025 01:46
@vigith vigith linked an issue Oct 20, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move pynumaflow and its related entities to a new a sub-dir

3 participants