-
Couldn't load subscription status.
- Fork 24
feature: gRPC #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Codecov Report
@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 85.43% 89.31% +3.88%
==========================================
Files 12 13 +1
Lines 309 337 +28
Branches 36 37 +1
==========================================
+ Hits 264 301 +37
+ Misses 40 34 -6
+ Partials 5 2 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Need help on the repo structure... @vigith |
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
| self._cleanup_coroutines.append(server_graceful_shutdown()) | ||
| await server.wait_for_termination() | ||
|
|
||
| def start(self) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
python notes:
run poetry shell before starting the development
gPRC notes:
(Copy the
https://github.com/numaproj/numaflow-go/blob/main/pkg/apis/protofolder and paste at the repo root, rename it toprotos)move the generated file to the
generatedfolderNOTE: need to manually add
from pynumaflow.function.generated import udfunction_pb2 as udfunction__pb2in the generatedudfunction_grpc_pb2 file.from pynumaflow.function.generatedis needed to importudfunction_pb2as mentioned in https://groups.google.com/g/grpc-io/c/hpPnAGY0ksQ.server.pyalso importsfrom pynumaflow.function.generated import udfunction_pb2 as udfunction__pb2If we find a proper fix we can replace the current
from..approach...udfunction_pb2.pyifile for the data types defined in the proto file.server.pyI refactor the code so that the function is using gRPC and sink is still using http.
Also need help with the code style/structure/design pattern etc.. not confident in those things
Thank you!
ref:
python gRPC testing pkg https://grpc.github.io/grpc/python/grpc_testing.html
python gRPC unit test example.. https://blog.masuqat.net/2018/04/16/grpc-python-unittest/
async graceful shutdown example https://github.com/lidizheng/grpc/blob/master/examples/python/helloworld/async_greeter_server_with_graceful_shutdown.py