Skip to content

Conversation

@jy4096
Copy link
Contributor

@jy4096 jy4096 commented Sep 16, 2022

add gRPC support for udsink

jyu6 added 7 commits September 16, 2022 12:55
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #5 (92c55a0) into main (496543c) will decrease coverage by 1.77%.
The diff coverage is 79.01%.

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   89.31%   87.54%   -1.78%     
==========================================
  Files          13        9       -4     
  Lines         337      273      -64     
  Branches       37       21      -16     
==========================================
- Hits          301      239      -62     
+ Misses         34       32       -2     
  Partials        2        2              
Impacted Files Coverage Δ
pynumaflow/sink/server.py 61.36% <61.36%> (ø)
pynumaflow/function/server.py 67.92% <100.00%> (-0.60%) ⬇️
pynumaflow/sink/__init__.py 100.00% <100.00%> (ø)
pynumaflow/sink/_dtypes.py 100.00% <100.00%> (+4.87%) ⬆️
pynumaflow/function/_dtypes.py 100.00% <0.00%> (+2.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

jyu6 added 5 commits September 16, 2022 15:11
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
@vigith vigith requested a review from ab93 September 19, 2022 17:09
@vigith vigith marked this pull request as ready for review September 19, 2022 17:09
@vigith vigith self-requested a review September 19, 2022 17:09
Copy link
Member

@ab93 ab93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments

Signed-off-by: jyu6 <juanlu_yu@intuit.com>
jy4096 and others added 6 commits September 19, 2022 11:08
Co-authored-by: Avik Basu <ab93@users.noreply.github.com>

Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Co-authored-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Co-authored-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Co-authored-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Co-authored-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Co-authored-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
jyu6 added 2 commits September 19, 2022 11:17
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Copy link
Member

@ab93 ab93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@ab93 ab93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems black format is failing. Can you fix?

Signed-off-by: jyu6 <juanlu_yu@intuit.com>
@jy4096 jy4096 requested a review from ab93 September 19, 2022 19:49
@ab93 ab93 merged commit 043e109 into numaproj:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants