-
Couldn't load subscription status.
- Fork 24
feature: udsink gRPC #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Codecov Report
@@ Coverage Diff @@
## main #5 +/- ##
==========================================
- Coverage 89.31% 87.54% -1.78%
==========================================
Files 13 9 -4
Lines 337 273 -64
Branches 37 21 -16
==========================================
- Hits 301 239 -62
+ Misses 34 32 -2
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor comments
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Co-authored-by: Avik Basu <ab93@users.noreply.github.com> Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Co-authored-by: Avik Basu <ab93@users.noreply.github.com> Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Co-authored-by: Avik Basu <ab93@users.noreply.github.com> Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Co-authored-by: Avik Basu <ab93@users.noreply.github.com> Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Co-authored-by: Avik Basu <ab93@users.noreply.github.com> Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Co-authored-by: Avik Basu <ab93@users.noreply.github.com> Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems black format is failing. Can you fix?
add gRPC support for udsink